Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCTRL-991]: Include timestamp in state related gRPC calls #665

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

justonedev1
Copy link
Collaborator

I added timestamp to all gRPC calls replies which is int64 unix timestamp in milliseconds.

@justonedev1 justonedev1 requested a review from knopers8 March 13, 2025 16:47
Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! My only concern is related to the point in time that these timestamps are taken. Sometimes it is at the moment of receiving the request, sometimes just before replying. If the request processing takes very little time, I guess it does not matter, but otherwise it could potentially be confusing. How about taking the timestamp always at the beginning of the call? This way it should bring minimal boilerplate code, but keep the behaviour consistent.

@justonedev1 justonedev1 requested a review from knopers8 March 14, 2025 18:31
@justonedev1
Copy link
Collaborator Author

I changed the code to address what you said. Please don't merge this after approving, I need to squash the fixup commit after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants