DPL: improve logs for new calibration scheme #14030
Conversation
- Report correct timeout for readers. - Improve message when dropping data which is not going to be processed by the CalibrationOnly mode.
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
| @@ -335,7 +337,11 @@ void DataRelayer::setOldestPossibleInput(TimesliceId proposed, ChannelIndex chan | |||
| if (element.size() == 0) { | |||
| auto& state = mContext.get<DeviceState>(); | |||
| if (state.transitionHandling != TransitionHandlingState::NoTransition && DefaultsHelpers::onlineDeploymentMode()) { | |||
| LOGP(warning, "Missing {} (lifetime:{}) while dropping incomplete data in slot {} with timestamp {} < {}.", DataSpecUtils::describe(input), input.lifetime, si, timestamp.value, newOldest.timeslice.value); | |||
| if (state.allowedProcessing == DeviceState::CalibrationOnly) { | |||
There was a problem hiding this comment.
In case we are in calibration mode, I would drop the MISSING message completely. It is expected to be missing, so no need to inform about it.
And then for the "Dropping lifetime::timeframe" warning, I would demote to info in calibration mode and pring " [INFO]: Not processing in calibration mode:...."
| } else { | ||
| O2_SIGNPOST_EVENT_EMIT_INFO(device, lid, "run_loop", "New state requested. Waiting for %d seconds before switching to READY state.", (int)deviceContext.exitTransitionTimeout); | ||
| O2_SIGNPOST_EVENT_EMIT_INFO(device, lid, "run_loop", "New state requested. Waiting for %d seconds before switching to READY state.", timeout); |
There was a problem hiding this comment.
Could we also add (as I wrote in https://its.cern.ch/jira/browse/O2-4308): For source devices like the readout-proxy, I would write "Waiting for DATAPROCESSING_TIMEOUT seconds before dropping the remaining input".
the CalibrationOnly mode.