Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRD: add optional(default=off) extra table for PID studies #14009

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

f3sch
Copy link
Collaborator

@f3sch f3sch commented Feb 28, 2025

This introduces a new table to be used for TRD pid studies and parameterisation via special requested passes.
Leaving as draft for now until we agree on exact table information.

Feature requested by Anton Andronic & Kangkan Goswami, discussion is via email.

From local test via

#!/usr/bin/env sh

GLOSET=" -b --shm-segment-size 4000000000 --hbfutils-config o2_tfidinfo.root,upstream --timeframes-rate-limit 1 --timeframes-rate-limit-ipcid 0 "

o2-reader-driver-workflow --max-tf 1 $GLOSET |
    o2-aod-producer-workflow $GLOSET \
        --info-sources ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,ITS,TPC,TOF,FT0,FDD,FV0,TRD,CTP \
        --aod-writer-keep dangling --aod-writer-resfile "AO2D_hasqc" --aod-writer-resmode RECREATE --disable-mc --aod-writer-maxfilesize 4000 \
        --lpmp-prod-tag LHC23zzh --reco-pass apass4_test5_debug_epn --trackqc-fraction 0.1 \
        --configKeyValues ";" --run --enable-TRD-extra --disable-strangeness-tracker

which looks reasonable to me:
image

Also includes a small cleanup to not output extra fit tables if not requested.

Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch force-pushed the trd/aod branch 2 times, most recently from 300a7db to bb91f20 Compare March 11, 2025 16:47
@f3sch
Copy link
Collaborator Author

f3sch commented Mar 11, 2025

@jgrosseo is it okay to retroactively add DECLARE_SOA_DYNAMIC_COLUMN(s) to versioned table? I assumed it is since the on-disk representation should not change, only on-the-fly build table includes 3 more columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant