Repository navigation
tech(recursion/nth-fibonacci): fibonacci - #2
Merged
Merged
Conversation
shangan23
requested changes
Jun 20, 2021
| defaultArray = [0,1] | ||
| count = 3 | ||
| while count <= n: | ||
| sumNo = defaultArray[0] + defaultArray[1] |
Contributor
There was a problem hiding this comment.
change sumNo variable to sum
Collaborator
Author
There was a problem hiding this comment.
Changed
| defaultArray[0] = defaultArray[1] | ||
| defaultArray[1] = sumNo | ||
| count = count + 1 | ||
| if n == 1: |
Contributor
There was a problem hiding this comment.
move this if-block before count init since there is no need for count assignment and further while check. correct me if I am wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1