Open
Conversation
…r BigCodeBench_OLMES task
fsschneider
approved these changes
Mar 18, 2026
Contributor
fsschneider
left a comment
fsschneider
left a comment
There was a problem hiding this comment.
LGTM. Just two small questions.
Comment on lines
+131
to
+133
| def __init__(self, num_fewshot: int = 5) -> None: | ||
| # Default 3-shot; config can override. Enforce 3 for this variant. | ||
| super().__init__(num_fewshot=3) |
Contributor
There was a problem hiding this comment.
I think this is a bit misleading, we default to num_fewshot: int =5, but it is actually overwritten and never used. Also it is silently changed to 3.
Comment on lines
+143
to
+146
| self.dockerfile = str(importlib.resources.files("eval_framework.tasks") / "Dockerfile_codebench") | ||
|
|
||
| def _count_correct_samples(self, completion: str, context: RealtimeCodeExectionContext) -> tuple[int, str]: | ||
| dockerfile = str(importlib.resources.files("eval_framework.tasks") / "Dockerfile_codebench") |
Contributor
There was a problem hiding this comment.
Is there a reason to duplicate the importlib.resources.files(...) part? Why not use self.dockerfile?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
/docs/).What type of PR is this? (check all applicable)
Description
Adds a variant of the BigCodeBench task which mimics the OLMES implementation.
Added/updated tests?
have not been included