Localisation Layer#603
Open
gruenwaldlk wants to merge 4 commits into
Open
Conversation
AnakinRaW
requested changes
Jun 11, 2026
AnakinRaW
reviewed
Jun 12, 2026
AnakinRaW
left a comment
AnakinRaW
left a comment
Member
There was a problem hiding this comment.
thx, look cool.
get rid of the hashing service registration in the core service contribution and i'm happy 👍🏼
| public static void SupportDAT(this IServiceCollection serviceCollection) | ||
| { | ||
| PetroglyphCommons.ContributeServices(serviceCollection); | ||
| serviceCollection.TryAddSingleton<IHashingService>(sp => new HashingService(sp)); |
Member
There was a problem hiding this comment.
providing the hashing service, for me, is also responsibility of the consumer
| serviceCollection.AddSingleton<IHashAlgorithmProvider>(new Crc32HashingProvider()); | ||
| serviceCollection.AddSingleton<ICrc32HashingService>(sp => new Crc32HashingService(sp)); | ||
| serviceCollection.TryAddSingleton<IHashAlgorithmProvider>(new Crc32HashingProvider()); | ||
| serviceCollection.TryAddSingleton<IHashingService>(sp => new HashingService(sp)); |
Member
There was a problem hiding this comment.
providing the hashing service, for me, is also responsibility of the consumer
| // Copyright (c) Alamo Engine Tools and contributors. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for details. | ||
|
|
||
| using System; |
Member
There was a problem hiding this comment.
i don't have a strong bias. but if xml is evenaully superseeded by a new format or dropped entirely. i'd be ok with a breaking change of the lib. and for now mark the thing as [Obsolete]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #316 finally.