fix: remove implicit requirement of vue-loader #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.loader` is a setter rather than a selector. `.use` alone is sufficient for selecting the loader rule <https://github.com/neutrinojs/webpack-chain#config-module-rules-uses-loaders-modifying-options> So this expression implicitly introduced a dependency on the `vue-loader` name, and expected it to be vue-loader v15, which, isn't guranteed to be exact the case. Because Vue CLI supports both Vue 2 and Vue 3 in the core service, the `vue-loader` dependency used to be v15 and v16 is aliases as `vue-loader-v16`. But when I tried to upgrade to webpack 5 and make v16 the default `vue-loader` dependency, it breaks this plugin and had to workaround it. See vuejs/vue-cli@7c672bd#diff-e201f09cd938f870f5a24c75f97cf10a2a16819caf5f5b154bcc23c4ff915239R99-R106
haoqunjiang
added a commit
to haoqunjiang/vue-cli
that referenced
this pull request
Dec 8, 2020
9 tasks
haoqunjiang
added a commit
to vuejs/vue-cli
that referenced
this pull request
Dec 9, 2020
…i] (#6128) See the reasoning at Akryum/vue-cli-plugin-apollo#463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.loaderis a setter rather than a selector..usealone is sufficient for selecting the loader rulehttps://github.com/neutrinojs/webpack-chain#config-module-rules-uses-loaders-modifying-options
So this expression implicitly introduced a dependency on the
vue-loadername, and expected it to be vue-loader v15, which, isn'tguranteed to be exact the case.
Because Vue CLI supports both Vue 2 and Vue 3 in the core service,
the
vue-loaderdependency used to be v15 and v16 is aliases asvue-loader-v16.But when I tried to upgrade to webpack 5 and make v16 the default
vue-loaderdependency, it breaks this plugin and I had toworkaround it.
See <
7c672bd(#6060)>