Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: playwrightを用いたe2eテストを追加 close #26 #46

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

yupix
Copy link
Contributor

@yupix yupix commented Mar 11, 2024

No description provided.

@sousuke0422
Copy link
Member

なんかテストpush/prで二重で走ってる

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

わかる

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

あと落ちてるのはローカルでも落ちてたけどモバイルのテストだけなんか落ちるっぽい

@sousuke0422
Copy link
Member

実は作りかけが自分の手元にもあったりする

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

Issueに自分を割り当てなかったのが悪いとしか言いようがない

@sousuke0422
Copy link
Member

テスト内容被ってないから移植するかも

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

ちなみに何をテストしてるんですか

@sousuke0422
Copy link
Member

トップページを正しく開けてるか

@sousuke0422
Copy link
Member

image

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

どこまで厳密にテストしてるの?(この要素がある~みたいなことをしていのかという質問)

@sousuke0422
Copy link
Member

  • トップページのタイトルが正しいか
  • レンダリングされているか(ランディングページのテキストを確認)

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

無限ロードの対策にはよさそう

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

なんかスクショのアーティファクトがダウンロードできない

image

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

スクショが他の環境でダウンロードできるならマージしてよさそう

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

sousukeの方であとで試してみて

@sousuke0422
Copy link
Member

ダウンロードできない

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

ウィルス判定?

@sousuke0422
Copy link
Member

はい

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

割と謎

@sousuke0422
Copy link
Member

圧縮率いじって直ればまだ楽なんだけどね

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

非圧縮にしてもいい 🤔

@yupix
Copy link
Contributor Author

yupix commented Mar 11, 2024

圧縮率最大にしたら治ったかも

@yupix yupix merged commit de6444d into master Mar 11, 2024
2 checks passed
@yupix yupix deleted the feat/add-e2e-test branch March 11, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants