Skip to content

Conversation

aikaterna
Copy link
Contributor

The cog that I am most confident about is horoscope as it's used on my bot almost daily. I didn't go through and test every cog fully, so some remaining code may need to be adjusted in the future.

advgoogle - no changes, already hidden
emote - sort of halfway fixed. you may want to look at it sometime. added data statement
geico - hidden, bash.org disappeared about 2 months ago but sometimes the site reappears in the future when this happens. The site you use for the quotes command is returning some sort of js-related challenge before it redirects to the quotes page, so not quite sure how to remedy that.
horoscope - fixed, fixed info, fixed data statement
longcat - fixed, fixed info, fixed data statement
loot - fixed, fixed info, fixed data statement
lootbox - fixed, fixed info, fixed data statement
points - fixed, fixed info, fixed data statement
strawpoll - hidden, strawpoll.me closed down in 2022
the100 - hidden because I don't have access to an API key to test, and it looks like they have a new version of the API from after this cog was made
trove - hidden, not quite sure how the troves are supposed to get populated in the cog data

Copy link
Owner

@Aioxas Aioxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just that thing with the failsafe function

elif not url.endswith("ttf"):
await ctx.send("This is not a .ttf font, please use a .ttf font. Thanks")
return
await ctx.send("Font has been saved")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...well that was some dumb code. I never let it download and save the custom font 😅 It would be telling you "yes your font is saved :D ...not."

img_buffer = BytesIO()
img.save(img_buffer, format='PNG')
img_buffer.seek(0)
return img_buffer
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so correct me if I'm wrong, now there is no persistent storing of the edited cookie, but it now exists as an image buffer which is then emptied into the discord.File uploader, yeah?

dailynum = re.findall(regex[5], test)
self.fortune_process(fortune[0])
await ctx.send("Your fortune is:", file=discord.File(str(bundled_data_path(self) / "cookie-edit.png")))
img_png = self.fortune_process(fortune[0])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a failsafe function for the cookie.png if for any weird reason the cookie file goes kapoof now that file_check fn is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants