Skip to content

Improve error message on non-200 status code #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitterpanda63 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve error message on non-200 status code #544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90677eb
instead of weird unknown_error give something descriptive
bitterpanda63 Dec 8, 2025
55bd6d4
imrpove logs
bitterpanda63 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions aikido_zen/background_process/api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,13 @@ def to_api_response(res: Response):
return res.json()
except Exception as e:
logger.debug(
"Trying to load json, failed: %s (body=%s)", str(e), res.text
"Parsing JSON response from core failed: %s (body=%s)",
str(e),
res.text,
)
return {"success": False, "error": "unknown_error"}
return {"success": False, "error": "json_parsing_failed"}
logger.debug("Parsing response from core failed: [%s] %s", status, res.text)
return {"success": False, "error": "status_code_not_200"}
Copy link
Member

@hansott hansott Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include actual status code?


def report(self, token, event, timeout_in_sec):
"""Report event to aikido server"""
Expand Down
Loading