-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Add mio config list
#93
base: main
Are you sure you want to change the base?
Conversation
Nice! |
i'll do and then maybe we want like |
I think it's already satisfactory for addressing #88 , though I would want to hear from others how it feels to navigate through this. And yeah, the intended interaction for changing configs was another part I wasn't sure about, so an interface for grabbing paths would be excellent. |
Thanks, Jonny for creating this. Just for my understanding: Why is there a stream-buffer-header ID and a wireless-200px ID. So it's not like streaming with a buffer-header file with the wireless MS is going to be one ID? For example, each pixel size on the image sensor will have a different ID? and will be combined with the wireless-XXpx file? So I think what I am saying is I am not sure if it would be intuitive to know which configuration to use. |
So see the second column, which says what kind of model it is. currently that's just the name of the class, but in the future once we have done more work to link e.g. each of the other cli commands to a given config model (the
this is just the first draft of a "list all configs" command. so there are tons of other things we will want here too! this is an example of making small iterable PRs - initial functionality with clear points where we can expand in the future the idea behind the design of this I agree it's sort of annoying to need to have both the
So that's what we're working towards, where we can break apart, recombine, etc. different configs together both provided by the package, within an experiment, across a user's machine, or included in some downstream package that bundles us. Hopefully that help explains why we would be seeing all configs and why that's a good thing - we want to be able to have a bunch of different types of configs for different models: those are all the configs and their ids you can use anywhere, in different cli commands, within config files, etc. And yes we will certainly continue to refine this interface and make use of that information to be able to filter and sort and show what you need to know, this isn't the final PR of the CLI. We will need to draw the line somewhere on this package to keep it functional for development and use in downstream packages, but doesn't try to bundle a ton of GUI and other stuff that we want to purposely keep separate to maintain modularity, but the CLI should be good. |
Re: #88 (comment)
how does this look
📚 Documentation preview 📚: https://miniscope-io--93.org.readthedocs.build/en/93/