Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: coverage #7207

Merged
merged 1 commit into from
Mar 22, 2023
Merged

ci: coverage #7207

merged 1 commit into from
Mar 22, 2023

Conversation

arirubinstein
Copy link
Contributor

@arirubinstein arirubinstein commented Mar 21, 2023 •
edited
Loading

Adds coverage reporting and codecov.io report uploading to CI

@datadog-full-agoric
Copy link

datadog-full-agoric bot commented Mar 21, 2023 •
edited
Loading

Datadog Report

Branch report: ari/coverage
Commit report: 179ef2b

✅ agoric-sdk: 0 Failed, 0 New Flaky, 3779 Passed, 55 Skipped, 24m 56.2s Wall Time

@arirubinstein arirubinstein force-pushed the ari/coverage branch 9 times, most recently from 8df827f to c8d97f9 Compare March 21, 2023 22:38
@codecov
Copy link

codecov bot commented Mar 21, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e687671). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7207   +/-   ##
=========================================
  Coverage          ?   79.40%           
=========================================
  Files             ?      390           
  Lines             ?    73957           
  Branches          ?        3           
=========================================
  Hits              ?    58725           
  Misses            ?    15231           
  Partials          ?        1

Impacted file tree graph

@arirubinstein arirubinstein force-pushed the ari/coverage branch 3 times, most recently from 59ca202 to afdea6a Compare March 21, 2023 23:01
@arirubinstein arirubinstein requested a review from turadg March 21, 2023 23:03
@arirubinstein arirubinstein removed the request for review from turadg March 21, 2023 23:23
@arirubinstein arirubinstein marked this pull request as draft March 21, 2023 23:24
@turadg
Copy link
Member

turadg commented Mar 21, 2023

I suspect this won't be worth pursuing until,

My understanding of the current state: #1664 (comment)

@arirubinstein arirubinstein force-pushed the ari/coverage branch 10 times, most recently from 01a6812 to c52338e Compare March 22, 2023 01:08
@arirubinstein arirubinstein force-pushed the ari/coverage branch 3 times, most recently from f1747a4 to c6508ad Compare March 22, 2023 01:27
@arirubinstein arirubinstein requested a review from turadg March 22, 2023 02:31
@arirubinstein arirubinstein marked this pull request as ready for review March 22, 2023 02:31
@arirubinstein
Copy link
Contributor Author

Curious about your thoughts @turadg - this basically productionizes diffs

turadg
turadg approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It's going to miss what's in Endo bundles but it does tell us a lower bound of coverage.

I support landing this to master so we can start seeing what value is has when reviewing a diff.

@arirubinstein arirubinstein added the automerge:rebase Automatically rebase updates, then merge label Mar 22, 2023
@mergify mergify bot merged commit 033b042 into master Mar 22, 2023
@mergify mergify bot deleted the ari/coverage branch March 22, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arirubinstein @turadg