test coverage over bundles #11100
Draft
test coverage over bundles #11100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
670e08f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aafbc22d.agoric-sdk.pages.dev |
| Branch Preview URL: | https://1817-bundle-coverage.agoric-sdk.pages.dev |
turadg
force-pushed
the
1817-bundle-coverage
branch
from
608f963 to
6f954ac
Compare
mhofman
reviewed
Mar 11, 2025
packages/zoe/tools/setup-zoe.js
Outdated
| moduleFormat: 'test', | ||
| [Symbol.for('exports')]: exports, | ||
| }); | ||
| id = `b1-test-exports-${Math.random()}`; |
There was a problem hiding this comment.
Interesting, this will also ensure that bundleAndInstall is only used from the privileged start compartment.
I'd like to emphasize this one. The next Endo version introduces a revamped bundler, and maintaining coverage through the endo sync will be invaluable for @kriskowal |
mhofman
reviewed
Mar 11, 2025
Comment on lines
+79
to
+81
| // Copy all the properties so this object can be hardened. | ||
| const exports = { ...pathOrExports }; | ||
| return bundleTestExports(exports); |
There was a problem hiding this comment.
Does anyone harden the returned bundle?
There was a problem hiding this comment.
FYI the version that ended up landing is quite a bit different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #1817
Description
Code coverage for bundles in unit tests!
Draft until this doesn't have to patch Endo (next Endo rev )
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations