chore(runner): upgrade Claude ACP adapter#5213
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🤖 The AI agent says: CI triage: all runner checks are green, including unit, integration, and acceptance. The red SDK job is two assertions in unchanged agent permission/capability tests; the red API job is six SSRF-validation assertions in unchanged secrets tests. Neither job touches the four-file runner dependency diff, so I left those unrelated failures out of this PR. |
Resolve the services/runner/pnpm-lock.yaml conflict by combining the ACP-upgrade lockfile from big-agents (#5213) with this branch's sandbox-agent patchedDependencies stanza.
Context
The runner still used the deprecated
@zed-industries/claude-agent-acp0.23.1 package. That release predates the adapter's native ACP effort configuration and no longer receives updates under the old package name.Changes
@agentclientprotocol/claude-agent-acp0.58.1.big-agents.package-lock.json; runner Docker builds and CI usepnpm-lock.yamlwith frozen installs.Before this change, local Claude sessions launched adapter 0.23.1 and exposed no ACP effort option. After the change, the adapter reports
effortin thethought_levelcategory and accepts model-supported values throughSession.setThoughtLevel().Testing
pnpm run typecheckpnpm install --frozen-lockfile --ignore-scriptsfrom currentbig-agentshttp://144.76.237.122:8280/api/healthand sidecar/health{ id: "effort", category: "thought_level" }, setlow, and read backcurrentValue: "low"/runthrough the rebuilt sidecar and received the exact expected responseEFFORT-ADAPTER-OKThe full runner suite completed 826 of 829 tests. Three existing tests still fail reproducibly on the unchanged source: one permission-responder microtask timing assertion and two Pi transcript replays. They are outside this dependency-only change; focused ACP coverage and type checking pass.
Notes
This upgrades the adapter used by local runner sessions. Daytona uses the adapter baked into its sandbox image and must be upgraded and verified separately before claiming parity there.
Upstream issue #851 reports a background Claude subagent permission-channel deadlock. This PR verifies the basic session/config path; the broader permission, cancellation, resume, and subagent matrix remains follow-up QA.