Use as_bytes_with_nul for deepsize of CString
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CString::as_bytes_with_nul` is cheap to call - it directly returns a reference to the inner byte slice. `as_bytes_with_nul` performs no allocations or validations. See: - https://doc.rust-lang.org/std/ffi/struct.CString.html#method.as_bytes_with_nul - https://doc.rust-lang.org/src/std/ffi/c_str.rs.html#635-637 `as_bytes_with_nul` has been stable since Rust 1.0.0.
lopopolo
commented
Nov 28, 2021
Comment on lines
-103
to
-104
| // doesn't seem avoidable. This assumes that the allocation | ||
| // is the exact length of the string and the added null |
There was a problem hiding this comment.
in practice this assumption is true since the inner repr of CString is a Box<[u8]> which is acquired by calling Vec::into_boxed_slice which documents that excess capacity is dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CString::as_bytes_with_nulis cheap to call - it directly returns areference to the inner byte slice.
as_bytes_with_nulperforms no allocations or validations.See:
as_bytes_with_nulhas been stable since Rust 1.0.0.