Skip to content

Fix fi-FI translation file #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix fi-FI translation file #3239

wants to merge 2 commits into from

Conversation

m1aw
Copy link
Contributor

@m1aw m1aw commented Apr 3, 2025

Summary

Fix errors in Finnish translations.

Tested scenarios

Fixed issue:
#3189

Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: d7b7a96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for adyen-web ready!

Name Link
🔨 Latest commit d7b7a96
🔍 Latest deploy log https://app.netlify.com/sites/adyen-web/deploys/67ee9f494cbe9600082f1e45
😎 Deploy Preview https://deploy-preview-3239--adyen-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarqubecloud bot commented Apr 3, 2025

Copy link
Contributor

github-actions bot commented Apr 3, 2025

size-limit report 📦

Path Size
UMD 102.33 KB (0%)
Auto 109.38 KB (0%)
ESM - Core 24.67 KB (0%)
ESM - Core + Card 61.51 KB (0%)
ESM - Core + Dropin with Card 66.13 KB (0%)

@sponglord
Copy link
Contributor

sponglord commented Apr 4, 2025

What's concerning here is that the problematic translation from issue #3189 for creditCard.holderName has not been re-translated and still remains as "Nimi kortilla" when the issue suggests it needs to be "Kortinhaltijan nimi"
but...
According to Smartling, commenting on this:

The original translation changed to "name of cardholder". Incorrect change. The original correctly reflects the cardholder's name as shown on the card.

So I guess we're good to go

@sponglord
Copy link
Contributor

sponglord commented Apr 4, 2025

I do notice however that one change Smartling agreed was correct for ctp.errors.FRAUD
Käyttäjätili oli lukittu tai poistettu käytöstä --> Käyttäjätili on lukittu tai poistettu käytöstä
("oli" --> "on")
hasn't made it into the new translation file

@sponglord sponglord closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants