-
Couldn't load subscription status.
- Fork 29
Open telemetry #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Open telemetry #413
Conversation
|
|
||
| ## Setup | ||
|
|
||
| In order for Adobe Commerce runtime actions to send telemetry signals to New Relic, you must configure the telemetry exporters to send data to the Open Telemetry Protocol (OTLP) ingestion endpoint provided by the platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| In order for Adobe Commerce runtime actions to send telemetry signals to New Relic, you must configure the telemetry exporters to send data to the Open Telemetry Protocol (OTLP) ingestion endpoint provided by the platform. | |
| For Adobe Commerce runtime actions to send telemetry signals to New Relic, you must configure the telemetry exporters to send data to the Open Telemetry Protocol (OTLP) ingestion endpoint provided by the platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of not accurate? This library works for any App Builder runtime actions, not only for Adobe Commerce.
src/pages/starter-kit/integration/telemetry/use-cases/new-relic.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Harper <[email protected]>
|
I unresolved some of the conversations with some notes of my own (some of them are collapsed by the UI, make sure you go over all of them). I applied some of the documentation suggestions listed by @keharper so that they auto-generate from source code with those changes. You can find latest docs state in here: adobe/aio-lib-telemetry#18 |
|
@keharper @jhadobe Not sure if this kind of reference is the first of it's kind (not an API, not a GraphQL, but a library reference) in Adobe documentation, but I'd seriously avoid manually modifying it as it will be a maintenance hell. I can automate a process that opens a PR in the Adobe documentation anywhere with the latest docs whenever a release of the library happens, if that eases the documentation workflow a bit. If you have concerns on the format we can have a talk on what can be improved or what you'd like to see different (acknowledging that there will be limitations). Let me know if this would work for you. FYI, the reference is generated from source code via TypeDoc combined with the Markdown plugin. Linking to both in case you want to investigate (if you're not familiar with them already). |
|
Also going to leave some examples here on what I have in mind for a "library API Reference", which is something I'm used to look when working with third-party libraries. |
|
Reverting this to a draft state, it will be on hold for a couple weeks. (Pending PM input on where these docs should be published.) |
This PR adds several pages regarding open telemetry for the integration starter kit.
Staging: https://developer-stage.adobe.com/commerce/extensibility/starter-kit/integration/telemetry/repurposed while this PR is on hold