Add support for regular expressions in $app modifier
#714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for regular expressions in `$app` modifier
add mix
sfionov
requested changes
Jun 26, 2025
|
|
||
| The `$app` modifier supports combining plain app names, negated app names, and regular expressions in the same rule. | ||
|
|
||
| - `||baddomain.com^$app=org.example.app|~org.example.excluded|/org\.example\.[a-z]+/` — applies to `org.example.app`, to all matching `org.example.[a-z]+` apps, and excludes `org.example.excluded`. |
There was a problem hiding this comment.
A negation and a non-negated expression cannot be in the same expression, because ~ essentially matches "everything except", and can only be combined with other ~ expressions to expand that "except". Otherwise, it leads to too many possible interpretations.
| You can use regular expressions in the `$app` modifier by enclosing them in forward slashes `/.../`. This allows for more flexible matching — for example, targeting a group of apps from the same publisher or matching complex patterns. | ||
|
|
||
| - `||baddomain.com^$app=/org\.example\.[a-z0-9_]+/` — applies to all apps whose package name starts with `org.example` (e.g. `org.example.app1`, `org.example.utility`, etc.). | ||
| - `||baddomain.com^$app=/^org\.example\.app$|^org\.example\.[ab].*/` — applies to `org.example.app` and to any app whose package starts with `org.example.a` or `org.example.b`. |
There was a problem hiding this comment.
$ and , should be escaped in modifiers, since unescaped $ means modifiers start, and , is modifiers separator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
$appmodifier documentation to include support for regular expressionsAdguardTeam/CoreLibs#1906