Describe changes to element hiding rules in CoreLibs 1.18 #692
Conversation
ngorskikh
requested review from
sfionov,
ameshkov,
Alex-302,
scripthunter7,
el-termikael and
anastasiia-fedotova
Co-authored-by: Helen <[email protected]>
| For example: | ||
|
|
||
| ```adblock | ||
| example.org##body { background-color: green; } |
There was a problem hiding this comment.
I suggest mentioning remove rules here, such as example.com##h1 { remove: true; }.
Another important point is that in the free version, only remove rules work — as far as I understand, other types of CSS injections (like coloring) are part of the premium ABP subscription.
ABP refers to these rules collectively as “Inline CSS” rules btw.
There was a problem hiding this comment.
Hmm, if that's the case, can we limit the support to remove: true and just not support their premium functionality? It makes little sense since the rules for that are a part of their premium bundle and it cannot be shared&used in other ad blockers.
|
|
||
| ```adblock | ||
| example.org#@#body | ||
| example.org#@#body { background-color: green; } |
There was a problem hiding this comment.
Basically, both options work in ABP, but what’s important is that ABP only checks the selector during allowlisting, while ADG checks the entire rule. We’ll probably need to resolve this inconsistency at some point.
cc @ameshkov
| For example: | ||
|
|
||
| ```adblock | ||
| example.org##body { background-color: green; } |
There was a problem hiding this comment.
Hmm, if that's the case, can we limit the support to remove: true and just not support their premium functionality? It makes little sense since the rules for that are a part of their premium bundle and it cannot be shared&used in other ad blockers.
| ``` | ||
|
|
||
| This usage is discouraged in favor of using [CSS rules](#cosmetic-css-rules) and is only supported for compatibility with filter lists written for Adblock Plus. | ||
|
|
||
| Element hiding exceptions (`#@#`) can match such a rule both by its selector part and by the full rule text. | ||
| For example, the rule `example.org##body { background-color: green; }` can be disabled by any of the following exception rules: | ||
| Element hiding exceptions (`#@#`) are matched by the selector part only, ignoring the declarations block part. |
There was a problem hiding this comment.
| Element hiding exceptions (`#@#`) are matched by the selector part only, ignoring the declarations block part. | |
| Element hiding exceptions (`#@#`) are matched by the selector part only, ignoring the declaration part. |
There was a problem hiding this comment.
{ remove: true; } is the declarations block, I'm refering to the part of the rule that is the declarations block :)
There was a problem hiding this comment.
I see
ignore my suggestion then :)
Subj.