[AG-31991] Remove complicated heuristics for $domain modifier #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
@workingBanana We need to retain info about deprecated behavior, but note that since CoreLibs 1.18 logic is simplified. Examples should mention both cases, though. |
Now that we have the `$to` modifier, `$domain` will no longer match the target domain by default - only when the `$csp` or `$cookie` modifiers are specified. See-also: AG-31991 Signed-off-by: Alexey Zhavoronkov <[email protected]>
workingBanana
force-pushed
the
feature/AG-31991
branch
from
137d503 to
83eaea6
Compare
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the
$tomodifier,$domainwill no longer match the target domain by default - only when the$cspor$cookiemodifiers are specified.