Skip to content

Conversation

CeliaBenquet
Copy link
Member

Parametrize offset models into a single OffsetNModel class so that we don't have to recreate a specific model for each new receptive field wanted. Instead, it can just be added to the list of parameters in the parametrize decorator.

This handles both odd and even receptive field sizes.

@CeliaBenquet CeliaBenquet self-assigned this Aug 22, 2025
@CeliaBenquet CeliaBenquet added the enhancement New feature or request label Aug 22, 2025
@cla-bot cla-bot bot added the CLA signed label Aug 22, 2025
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative, thanks --- but add tests that confirm that the previously hardcoded models are 1:1 the same. You can do this by:

  • copy pasting the old model code to the test folder as reference implementation
  • instantiate with the new code, and check that all kinds of properties match 1:1

If this is hard to achieve, the alternative is to just let old and new models co-exist :)

e.g. use "varoffset-10-model" or so for the new ones?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants