-
Notifications
You must be signed in to change notification settings - Fork 146
Nested routes #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Nested routes #137
Conversation
…ll with one entry works now
…fill_empties_with_defaults'. made is_complete default to False if nothing is entered for 'completed_at'
… endpoints working
…I want to save my progress just in case I'm on track.
…slack when a task is complete. all tests are still working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. You hit the learning goals here. Well done. I left some minor comments in the code. If you have questions please ping me in Slack.
"text": "Someone just completed the task " + task.title | ||
} | ||
headers = { | ||
"Authorization" : "Bearer " + os.environ.get("SLACK_API_KEY") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason Learn is failing is that the Environment variable used by Learn is not named SLACK_API_KEY and so os.environ.get("SLACK_API_KEY")
returns None
.
return make_response(response_body, 200) | ||
|
||
#ideally, combine this with validate goal, passing in the class as well. | ||
def validate_task(task_id): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice helper function!
#can I make this a method for Tasks? | ||
def update_given_values(task, request_body): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can indeed make this a method in the tasks class. It would make a great helper method.
No description provided.