Skip to content

Nested routes #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Nested routes #137

wants to merge 35 commits into from

Conversation

theLP100
Copy link

No description provided.

…fill_empties_with_defaults'. made is_complete default to False if nothing is entered for 'completed_at'
…I want to save my progress just in case I'm on track.
…slack when a task is complete. all tests are still working.
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. You hit the learning goals here. Well done. I left some minor comments in the code. If you have questions please ping me in Slack.

"text": "Someone just completed the task " + task.title
}
headers = {
"Authorization" : "Bearer " + os.environ.get("SLACK_API_KEY")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason Learn is failing is that the Environment variable used by Learn is not named SLACK_API_KEY and so os.environ.get("SLACK_API_KEY") returns None.

return make_response(response_body, 200)

#ideally, combine this with validate goal, passing in the class as well.
def validate_task(task_id):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice helper function!

Comment on lines +118 to +119
#can I make this a method for Tasks?
def update_given_values(task, request_body):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can indeed make this a method in the tasks class. It would make a great helper method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants