Time - Yaz by saintmedusa · Pull Request #47 · Ada-C13/task-list

saintmedusa · 2020-05-17T02:44:19Z

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe in your own words what the Model is doing in Rails	The model is keeping track of task attributes (via columns), individual task records (rows) and changes to the way we keep track of tasks.
Describe in your own words what the Controller is doing in Rails	the controller is processing the data that comes in when the user interacts with the view.
Describe in your own words what the View is doing in Rails	The view is displaying information and options to the user.
Describe an edge-case controller test you wrote	didn't write tests
What is the purpose of using strong params? (i.e. the params method in the controller)	I don't have a params method
How are Rails migrations related to Rails models?	migrations keekp track of changes to the database, and are the method for creating change
Describe one area of Rails that are still unclear on	params

…rb. Created basic, corresponding erb view and css.

… of each task

… and corresponding views for show + index views.

… create and new, and coressponding route. Link to add new task is now at the bottom of index page.

…of all tasks

dHelmgren · 2020-05-20T00:02:34Z

Task List

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages	✔️
Routes follow RESTful conventions	✔️
Uses named routes (like `_path`)	✔️
Creates Models and migrations	✔️ (You made a list controller and IDK why, as it isn't in reqs)
Creates styled views
Handles errors like nonexistant tasks
Uses `form_with` to render forms in Rails	✔️

Functional Requirements/Manual Testing

Functional Requirement	yes/no
Successfully handles index & show	✔️
index & show tests pass
Successfully handles: New, Create	fails because there is no way to set the List from the task#new controller. I had to manually create a List to make the other routes work. The form doesn't let me add a list.
New, Create tests pass
Successfully handles: Edit, Update	✔️
Successfully handles: Destroy, Task Complete	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	5+ in Code Review && 5+ in Functional Requirements
Yellow (Approaches Standards)	3+ in Code Review && 4+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard)	0-2 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention	✔️

dHelmgren · 2020-05-19T23:59:47Z

db/migrate/20200517070021_create_lists.rb

+    create_table :lists do |t|
+      t.string :name
+
+      t.timestamps


Not sure why this is here, it causes problems in your create route.

dHelmgren · 2020-05-20T00:00:57Z

app/views/tasks/edit.html.erb

+<%= form_with model: @task do |f| %>
+
+  <%= f.label :name %>
+  <%= f.text_field :name %>
+
+  <%= f.label :description %>
+  <%= f.text_field :description %>
+
+  <%if @task.completed%>
+    <%= f.label :completed_at%>
+    <%= f.datetime_field :completed_at%>
+  <%end%>
+
+  <%= f.submit "update task" %>


This is a good place to use a form partial.

jmaddox19 · 2020-05-20T21:56:42Z

app/controllers/tasks_controller.rb

+  end
+
+  def format_datetime(datetime_string)
+    time_array = datetime_string.split(/\D/)


I'm getting the following error when trying to edit a task: undefined method 'split' for nil:NilClass
It's pointing at this line.

jmaddox19 · 2020-05-20T22:01:06Z

app/controllers/tasks_controller.rb

+    end
+  end
+
+  def mark_complete


I haven't figured out why but this is not succeeding for me in updating the task to complete.

jmaddox19 · 2020-05-20T22:06:24Z

app/controllers/tasks_controller.rb

+  def show
+    @task = Task.find_by(id: params[:id])
+    if @task.nil?
+      head :not_found


Devin marked the project as not handling non-existent tasks because the thing most people did here was a redirect but this is fine for now as well.
For MediaRanker, we will want to do a redirect in addition to flash messages to keep the user on a functioning page while also giving clear messaging to the user that what they were looking for is not there.

jmaddox19

Task List

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages	✔️
Routes follow RESTful conventions	✔️
Uses named routes (like `_path`)	✔️
Creates Models and migrations	✔️
Creates styled views	No but not required
Handles errors like nonexistant tasks	Sort of, but not with a redirect like the later lessons recommend. For MediaRanker, we will want to do a redirect in addition to flash messages to keep the user on a functioning page while also giving clear messaging to the user that what they were looking for is not there.
Uses `form_with` to render forms in Rails	✔️

Functional Requirements/Manual Testing

Functional Requirement	yes/no
Successfully handles index & show	✔️
index & show tests pass
Successfully handles: New, Create	✔️
New, Create tests pass
Successfully handles: Edit, Update	✔️
Successfully handles: Destroy, Task Complete	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	5+ in Code Review && 5+ in Functional Requirements
Yellow (Approaches Standards)	3+ in Code Review && 4+ in Functional Requirements, or the instructor judges that this project needs special attention	✔️
Red (Not at Standard)	0-2 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

jmaddox19 · 2020-05-22T23:43:12Z

config/routes.rb

+  get '/tasks/:id', to: 'tasks#show', as: 'task'
+  get '/tasks/:id/edit', to: 'tasks#edit', as: 'edit_task'
+  patch '/tasks/:id', to: 'tasks#update'
+  patch '/tasks.:id', to: 'tasks#mark_complete', as: 'mark_complete'


This totally still works because the code uses the alias but I think you intended for this to be a / instead of a .

jmaddox19 · 2020-05-22T23:44:06Z

config/routes.rb

@@ -1,3 +1,14 @@
 Rails.application.routes.draw do
  # For details on the DSL available within this file, see https://guides.rubyonrails.org/routing.html
+  # collection of tasks


In the future, it'll be important to have a root path to make your application more user-friendly.
Right now, I need to know to navigate to the /tasks path to be able to use the site.

saintmedusa added 11 commits May 15, 2020 20:19

Set up TaskController with #index and put its route in config/routes.…

11afbe1

…rb. Created basic, corresponding erb view and css.

Created Task model, migrated, and changed index view to show the name…

690df95

… of each task

fixed typos keeping task list from rendering

1de17d1

task controller now has working show action, with corresponding route…

4c58c36

… and corresponding views for show + index views.

created form for new task in new.html.erb, corresponding task#actions…

c7876b6

… create and new, and coressponding route. Link to add new task is now at the bottom of index page.

changed redirect when new task is add to be added task page, instead …

16bcc93

…of all tasks

indivdual task page now has link back to all tasks

6a043e3

created edit form and mark complete option

463d737

added delete task

8526f45

added validation for task name

aa03ac7

added ability to edit completed_at date/time

2a4e292

dHelmgren reviewed May 20, 2020

View reviewed changes

jmaddox19 reviewed May 20, 2020

View reviewed changes

saintmedusa force-pushed the master branch from 9a0dab3 to 2a4e292 Compare May 22, 2020 23:23

jmaddox19 reviewed May 22, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Time - Yaz#47

Time - Yaz#47
saintmedusa wants to merge 11 commits intoAda-C13:masterfrom
saintmedusa:master

saintmedusa commented May 17, 2020

Uh oh!

dHelmgren commented May 20, 2020 •

edited by jmaddox19

Loading

Uh oh!

dHelmgren May 19, 2020

Uh oh!

dHelmgren May 20, 2020

Uh oh!

jmaddox19 May 20, 2020

Uh oh!

jmaddox19 May 20, 2020

Uh oh!

jmaddox19 May 20, 2020 •

edited

Loading

Uh oh!

jmaddox19 left a comment

Uh oh!

jmaddox19 May 22, 2020

Uh oh!

jmaddox19 May 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

saintmedusa commented May 17, 2020

Task List

Comprehension Questions

Uh oh!

dHelmgren commented May 20, 2020 • edited by jmaddox19 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task List

Major Learning Goals/Code Review

Functional Requirements/Manual Testing

Overall Feedback

Uh oh!

dHelmgren May 19, 2020

Choose a reason for hiding this comment

Uh oh!

dHelmgren May 20, 2020

Choose a reason for hiding this comment

Uh oh!

jmaddox19 May 20, 2020

Choose a reason for hiding this comment

Uh oh!

jmaddox19 May 20, 2020

Choose a reason for hiding this comment

Uh oh!

jmaddox19 May 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmaddox19 left a comment

Choose a reason for hiding this comment

Task List

Major Learning Goals/Code Review

Functional Requirements/Manual Testing

Overall Feedback

Uh oh!

jmaddox19 May 22, 2020

Choose a reason for hiding this comment

Uh oh!

jmaddox19 May 22, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dHelmgren commented May 20, 2020 •

edited by jmaddox19

Loading

jmaddox19 May 20, 2020 •

edited

Loading