Open
Conversation
…issue with the function to mark complete.
Task ListMajor Learning Goals/Code Review
Functional Requirements/Manual Testing
Overall Feedback
| Red (Not at Standard) | 0-2 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention | ✔️ |
dHelmgren
reviewed
May 19, 2020
| end | ||
|
|
||
| def create | ||
| @task = Task.new(task_params) |
There was a problem hiding this comment.
You never initialize task_params so this always fails.
This is an example of how you might create the strong params:
def task_params
return params.require(:task).permit(:id, :name, :description, :completed_at)
end
There was a problem hiding this comment.
you would do this at the bottom of the file, not inside create
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…issue with the function to mark complete.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions