Space - Katie by ktvoort123 · Pull Request #39 · Ada-C13/task-list

ktvoort123 · 2020-05-05T17:19:55Z

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe in your own words what the Model is doing in Rails	The Model in Rails is dealing with the data for the application and interacts with the database.
Describe in your own words what the Controller is doing in Rails	The controller is the central processing of a rails app.
Describe in your own words what the View is doing in Rails	The view takes in data and outputs HTML.
Describe an edge-case controller test you wrote	N/A
What is the purpose of using strong params? (i.e. the params method in the controller)	Strong params prevents assigning request parameters to objects unless they have been explicitly permitted.
How are Rails migrations related to Rails models?	A Migration is a change to a database schema. The Model is a class that is being represented by the database schema.
Describe one area of Rails that are still unclear on	I get the most confused in Rails differentiating what Rails does with its 'magic' and what I have to do.

CheezItMan · 2020-05-07T23:00:06Z

Task List

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages	✔️
Routes follow RESTful conventions	✔️
Uses named routes (like `_path`)	✔️
Creates Models and migrations	✔️
Creates styled views	✔️, html is good not much styling
Handles errors like nonexistant tasks	✔️
Uses `form_with` to render forms in Rails	✔️

Functional Requirements/Manual Testing

Functional Requirement	yes/no
Successfully handles index & show	✔️
index & show tests pass	✔️
Successfully handles: New, Create	✔️
New, Create tests pass	✔️
Successfully handles: Edit, Update	✔️
Successfully handles: Destroy, Task Complete	✔️, I would suggest making this toggle between complete and incomplete tasks

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	5+ in Code Review && 5+ in Functional Requirements

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

Summary

Nicely done, you hit the learning goals here. You've definitely demonstrated an understanding of the lessons we modeled in Ada Books. Good luck with Rideshare!

CheezItMan · 2020-05-07T22:49:51Z

config/routes.rb

@@ -0,0 +1,20 @@
+Rails.application.routes.draw do


CheezItMan · 2020-05-07T22:50:25Z

app/views/layouts/application.html.erb

+    <h1>Welcome to Tasks List</h1>
+    <nav>
+      <ul>
+        <li><%= link_to "Create a new task", new_task_path %></li>
+        <li><%= link_to "View all tasks", tasks_path %></li>
+
+      </ul>
+    </nav>
+  </header>


I like this, but it should be the <body> tag.

CheezItMan · 2020-05-07T22:51:26Z

app/views/tasks/edit.html.erb

@@ -0,0 +1,11 @@
+<%= form_with model: @task, class: 'edit-task' do |f| %>


I realize this was reading after Task-List was due, but in future projects you can dry things up like this form with a partial view. Just a reminder.

CheezItMan · 2020-05-07T22:51:45Z

app/views/tasks/index.html.erb

+<ul>
+  <%@tasks.each do |task|%>
+    <li>
+      <%= link_to task.name, task_path(task) %> <%= button_to "Delete Task", task_path(task), method: :delete, data: {confirm: "Are you sure?"}%> <%= button_to "Complete Task", task_complete_path(task), method: :patch%> 


This is a really long line, maybe break this up over multiple lines.

CheezItMan · 2020-05-07T22:53:05Z

app/controllers/tasks_controller.rb

+      redirect_to task_path(@task.id) 
+      return
+    else
+      render :new, :bad_request # show the new task form view again


I just find this more readable, but I think yours is correct too.

Suggested change

render :new, :bad_request # show the new task form view again

render :new, status: :bad_request # show the new task form view again

CheezItMan · 2020-05-07T22:53:44Z

app/controllers/tasks_controller.rb

+      redirect_to task_path(@task.id)
+      return
+    else
+      render :edit


Suggested change

render :edit

render :edit, status: :bad_request

CheezItMan · 2020-05-07T22:54:16Z

app/controllers/tasks_controller.rb

+      redirect_to task_path(@task.id)
+      return
+    else
+      render :edit


Why render edit here? Maybe instead just redirect them someplace.

ktvoort123 added 12 commits May 2, 2020 13:07

completed Baseline

77d3248

completed wave 1 and passed the tests

1a79618

created show task, created new task page

20f72db

created the create function to make a new task

0b72660

changed the redirect in create to the show page for the new task

b075922

changed show to redirect to tasks path if the task is not found

faa9d0d

created edit.html.erb file and the edit method in the controller

975b4b0

completed wave 3 -- added the update function to the controller

7a06d96

created destroy method in controller

06087bb

added delete link in show and edit views

81dd791

added completed at route and action and added to the index view

00177ff

changed all links for actions to button_to's

56fcf6c

CheezItMan reviewed May 7, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Space - Katie#39

Space - Katie#39
ktvoort123 wants to merge 12 commits intoAda-C13:masterfrom
ktvoort123:master

ktvoort123 commented May 5, 2020

Uh oh!

CheezItMan commented May 7, 2020

Uh oh!

CheezItMan May 7, 2020

Uh oh!

CheezItMan May 7, 2020

Uh oh!

CheezItMan May 7, 2020

Uh oh!

CheezItMan May 7, 2020

Uh oh!

CheezItMan May 7, 2020

Uh oh!

CheezItMan May 7, 2020

Uh oh!

CheezItMan May 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,11 @@
		<%= form_with model: @task, class: 'edit-task' do \|f\| %>

	render :new, :bad_request # show the new task form view again
	render :new, status: :bad_request # show the new task form view again

Conversation

ktvoort123 commented May 5, 2020

Task List

Comprehension Questions

Uh oh!

CheezItMan commented May 7, 2020

Task List

Major Learning Goals/Code Review

Functional Requirements/Manual Testing

Overall Feedback

Code Style Bonus Awards

Summary

Uh oh!

CheezItMan May 7, 2020

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 7, 2020

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 7, 2020

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 7, 2020

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 7, 2020

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 7, 2020

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 7, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants