Open
Conversation
CheezItMan
reviewed
Apr 2, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Outstanding work, you hit all the learning goals here. Well done.
Take a look at my comments and let me know if you have any questions.
| @@ -1,3 +1,19 @@ | |||
| def intersection(list1, list2) | |||
| @@ -1,4 +1,21 @@ | |||
|
|
|||
| def palindrome_permutation?(string) | |||
| raise NotImplementedError, "permutations? not implemented" | ||
| end No newline at end of file | ||
|
|
||
| def str_to_hash(string) |
There was a problem hiding this comment.
Mostly a style comment: I don't like putting a method in a method in Ruby. In JavaScript it's natural, not so much here.
Comment on lines
+24
to
+28
| if string1_hash != string2_hash | ||
| false | ||
| else | ||
| true | ||
| end |
There was a problem hiding this comment.
Suggested change
| if string1_hash != string2_hash | |
| false | |
| else | |
| true | |
| end | |
| return string1_hash != string2_hash |
| @@ -1,4 +1,29 @@ | |||
|
|
|||
| def permutations?(string1, string2) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.