Open
Conversation
CheezItMan
reviewed
Feb 25, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Really nice work, you hit the main learning goals here. Try to give some thought as to the time/space complexities. Otherwise awesome work.
Comment on lines
21
to
23
| # Time Complexity: | ||
| # Space Complexity: | ||
| def add(key, value) |
Comment on lines
64
to
66
| # Time Complexity: | ||
| # Space Complexity: | ||
| def find(key) |
Comment on lines
+90
to
92
| # Time Complexity: O(n) because I went through each node once | ||
| # Space Complexity: O(n) because a stack was created | ||
| def inorder |
Comment on lines
105
to
107
| # Time Complexity: | ||
| # Space Complexity: | ||
| def preorder |
Comment on lines
122
to
124
| # Time Complexity: | ||
| # Space Complexity: | ||
| def postorder |
Comment on lines
140
to
142
| # Time Complexity: | ||
| # Space Complexity: | ||
| def height |
There was a problem hiding this comment.
Time/space complexity?
Otherwise well done
Comment on lines
161
to
164
| # Optional Method | ||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def bfs |
There was a problem hiding this comment.
Nice work on the optional.
Now what about time & space complexity?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.