Conversation
CheezItMan
reviewed
Feb 25, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit the basic learning goals, with some issues on space/time complexity. Check out my comments and let me know if you have any questions.
lib/tree.rb
Outdated
Comment on lines
19
to
21
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) | ||
| def add_helper(current_node, key, value) |
There was a problem hiding this comment.
The space complexity is O(log n) if the tree is balanced and O(n) if it's not.
lib/tree.rb
Outdated
Comment on lines
37
to
39
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) | ||
| def find_helper(current_node, key) |
There was a problem hiding this comment.
The space complexity is O(log n) if the tree is balanced and O(n) if it's not.
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def inorder |
|
|
||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def postorder |
|
|
||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def preorder |
Comment on lines
101
to
103
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def height_helper(current_node) |
There was a problem hiding this comment.
The space complexity here depends on the recursive calls which depend on the height of the tree. So the space complexity is O(log n) for balanced trees and O(n) for unbalanced ones.
Otherwise the method is quite well done! 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.