Open
Conversation
CheezItMan
reviewed
Dec 18, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
This isn't working and it's clear from the tests it's not working. You do have reversing a string done, but little else is in place. I'm glad you got what you finished in, but take a look at my comments and let me know if they give you an idea where you could have proceeded from there.
| initial += 1 | ||
| last -= 1 | ||
|
|
||
| return sentence |
There was a problem hiding this comment.
This return should be outside the while loop
Comment on lines
+26
to
+31
| (min..max).each do |length| | ||
| sky_arr.each do |word| | ||
| if word.length == length | ||
| final_arr << word | ||
| end | ||
| end |
There was a problem hiding this comment.
This looks like it works, but it's a little inefficient. Instead you could just do a bubblesort using the string lengths.
| # shovel into my_new_array | ||
| # in a perfect world, would return in order we want | ||
|
|
||
| def reverse(sentence) |
There was a problem hiding this comment.
This method reverses a string, it doesn't reverse the words in a sentence. You're on the right track.
Consider:
- Reverse the string
- Loop through reversing each word in the sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting & Reverse Sentence