Open
Conversation
CheezItMan
reviewed
Oct 10, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit the learning goals here. Well done. Take a look at my comments and let me know if you have any questions.
Comment on lines
+10
to
18
| def reverse(text, text_start, text_end) | ||
| i = 0 | ||
| ((text_end - text_start)/2).times do | ||
| temp_char = text[text_start + i] | ||
| text[text_start + i] = text[text_end - i - 1] | ||
| text[text_end - i - 1] = temp_char | ||
| i += 1 | ||
| end | ||
| end |
There was a problem hiding this comment.
Great helper method.
Could you have used it in other places in the main method?
| # Space complexity: ? | ||
| def reverse_sentence(my_sentence) | ||
| raise NotImplementedError | ||
| # Time complexity: O(n + m) - |
There was a problem hiding this comment.
You're reversing the whole string = n
Then you go through and reverse each word for a total of < n letters reversed
So O(2n) = O(n)
Comment on lines
+27
to
+32
| while letter < my_sentence.length/2 do | ||
| temp_char = my_sentence[letter] | ||
| my_sentence[letter] = my_sentence[length - 1 - letter] | ||
| my_sentence[length - 1 - letter] = temp_char | ||
| letter += 1 | ||
| end |
| end | ||
| end | ||
| my_sorted_array.push(current_word) | ||
| my_array.delete(current_word) |
There was a problem hiding this comment.
Just note .delete is an O(n) operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting & Reverse Sentence