Open
Conversation
CheezItMan
reviewed
Oct 9, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work. You hit the learning goals here. Check out my comments and let me know if you have any questions.
lib/reverse_sentence.rb
Outdated
Comment on lines
66
to
72
| def pairs_helper(length) | ||
| if length % 2 == 0 | ||
| pairs = length / 2 | ||
| else | ||
| pairs = (length - 1) / 2 | ||
| end | ||
| return pairs |
There was a problem hiding this comment.
I don't think this method is really needed as dividing an odd length by 2 will automatically round down.
lib/reverse_sentence.rb
Outdated
Comment on lines
14
to
18
| (sentence_pairs).times do | ||
| temp = my_sentence[i-1] | ||
| my_sentence[i-1] = my_sentence[-i] | ||
| my_sentence[-i] = temp | ||
| i += 1 |
There was a problem hiding this comment.
Notice that you're reversing a couple of times in this method. Could you instead make a helper method. That would dry this out.
lib/reverse_sentence.rb
Outdated
| def reverse_sentence(my_sentence) | ||
| raise NotImplementedError | ||
| # Time complexity: O(n2) | ||
| # Space complexity: O(n) |
There was a problem hiding this comment.
Correct where n is the number of words.
lib/sort_by_length.rb
Outdated
| # Time complexity: O(n2) | ||
| # Space complexity: O(n) | ||
|
|
||
| def sort_by_length(my_sentence) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting & Reverse Sentence