Open
Conversation
added 6 commits
September 22, 2019 15:52
…ests. Checked path relatives.
… Still only passing three tests in Ruby.
… sentence (Yoda => adoY) but I can't figure out how to un-reverse words post transformation.
CheezItMan
reviewed
Oct 9, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
A good start. You're definitely not finished with reverse sentence however. Take a look at my comments and let me know if this helps.
| def reverse_sentence(my_sentence) | ||
| raise NotImplementedError | ||
|
|
||
| def reverse_sentence(test_string) |
There was a problem hiding this comment.
Right now you're only reversing the sentence. You then need to do another loop reversing each word. Something to work on.
Comment on lines
3
to
4
| # Time complexity: ? | ||
| # Space complexity: ? |
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: This is an insertion sort with two loops, so time complexity is O(n^2) / quadratic | ||
| # Space complexity: O(1) / constant |
There was a problem hiding this comment.
Technically here since you're doing .split you're making a new array of words. So this is O(n)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting & Reverse Sentence