Open
Conversation
CheezItMan
reviewed
Oct 9, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you however made a new array of words instead of reversing the sentence in place. Think about this:
- reverse the sentence in place
- Loop through the sentence
- Then reversing each word in place (you can use a helper method that reverses the same in step 1).
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) - my method does not have any nested loops, but it will run through the length of the original string multiple times | ||
| # Space complexity: O(n) - a second variable (reverse) needs to be created, which will take up as much space as the original string |
There was a problem hiding this comment.
You were asked to reverse the sentence in place. So think if you can do this with O(1) space complexity.
| # sorted by the length of the word. | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n^2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting & Reverse Sentence