Open
Conversation
CheezItMan
reviewed
Apr 1, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Awesome work! You hit all the learning goals here. Well done.
Comment on lines
+2
to
+8
| # Time Complexity: O(n) | ||
| ## The method iterates over the entire array but does so only once | ||
|
|
||
| # Space Complexity: O(1) | ||
| ## There are a limited number of variables that are constantly being re-assessed, so as the input goes to infitity the space requirements do not grow. | ||
|
|
||
| def max_sub_array(number_array) |
Comment on lines
+3
to
8
| # Time complexity: O(n) | ||
| ## As the number goes to infinity, its values have to be assessed relative to whatever's already in the array, but because it's based on an array, the look-up cost is very low given that an index value is being passed in. | ||
| # Space Complexity: O(n) | ||
| ## As the number goes to infinity, the amount of space will grow at the same rate | ||
|
|
||
| def newman_conway(num) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.