LJ API Muncher

[elle-johnnie]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, and how did you try querying the API?	I read through the documentation and tested it out with Postman
What is an API Wrapper? Why is it in lib? How would your project change if you needed to interact with more than one API (aka more than just the Edamam API)?	An API Wrapper stands in place of a rails model, it creates ruby objects based off of API response json and enables the controller to collect the object data to pass it to the view.
Describe your API wrapper, the methods you created in it, and why you decided to create those methods/how they were helpful	I have 2 methods in my API wrapper one to build a list of recipes based on the search params and another to query edamam for a specific recipe and it's information.
What was an edge case or failure case test you wrote for your API Wrapper? What was a nominal case?	An edge case I tested was where invalid input was put into the search bar.
How does VCR aid in testing an API?	The VCR records any new API requests and utilizes them for testing later, this minimizes the total requests made throughout testing.
What is the Heroku URL of your deployed application?	https://ljs-munchies-app.herokuapp.com/

[dHelmgren]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Not great, you should be committing smaller chunks if you can!
Comprehension questions	I want to adjust your understanding of the API wrapper: It's not a replacement for a model, it's more like a foreign language interpreter. It takes data coming in from other sites and translates it into something you can use, rather than having everybody (each piece of your project) learn how to talk to the API.
General
Rails fundamentals (RESTful routing, use of named paths)	yes, see comments
Semantic HTML	No, your index page is divs all the way down!
Errors are reported to the user	No, see comments on routes.rb
API Wrapper to handle the API requests	yes
Controller testing
Lib testing
Search Functionality	yes
List Functionality	yes
Show individual item functionality	yes
Styling
List view shows 10 items at a time and/or has pagination	yes
Attractive and usable UI	Yes
API Features
The App attributes Edamam	Not on the index page.
The VCR cassettes do not contain the API key	no. :'(
External Resources
Link to deployed app on Heroku
Overall	Good work on the project! It hits the majority of the requirements, but you haven't tested the edge cases of you site the way I would hope.

[dHelmgren]

Could you use resources for the index and show pages?

[dHelmgren]

Is there a way to merge show_recipe and create_recipe?

[dHelmgren]

You've written your API wrapper to raise an error if the API call fails, but you're not looking for an error here. You should wrap this call in a begin/rescue.

Not doing so affects your ability to catch fail states and properly redirect the user.

[dHelmgren]

nooooooo app keeeeeyyyyyyy

[dHelmgren]

There are some interesting cases you're not covering here:

• What happens if no search term is provided?
• What if the search returns no results?

It might also be worthwhile to add some tests around the paging parameters:

• What happens if they're absent?
• Do you get different results when they change?
• What if you send a bogus value, like a negative page number?

[dHelmgren]

What if they give you a bad recipe?