Detect modules #11
Detect modules #11
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to addd234 in 48 seconds
More details
- Looked at
99lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src-tauri/src/manager.rs:73
- Draft comment:
The removal of 'awk' from the set of detected executables is a specific handling for Unix systems to avoid false positives. Consider documenting this behavior in the function's comments to clarify the intent for future maintainers. - Reason this comment was not posted:
Confidence changes required:33%
The functionget_watchers_in_pathin both Unix and Windows configurations is designed to detect executables starting with 'aw' in the PATH directories. However, the function removes 'awk' from the set of detected executables, which is specific to Unix systems. This is done to avoid false positives as 'awk' is a common Unix utility but not related to the intended 'aw' modules. The function uses a HashSet to ensure uniqueness and then converts it to a Vec. The use of metadata and permissions checks ensures that only executable files are considered.
Workflow ID: wflow_6KiFPNVEgQA3UU7J
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 28a093e in 2 minutes and 25 seconds
More details
- Looked at
171lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src-tauri/src/manager.rs:174
- Draft comment:
The functionsend_sigtermhas redundant return statements. Consider removing the unnecessaryOk(())at the end of the function.
}
}
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_o3B52dDJoG0JfN8S
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
|
Link the related issue too, I can't. I don't have the necessary permissions I guess |
|
@brayo-pip Just mention it in the issue description, like so: "Closes #issue_number" |
|
I don't have the gear icons here |
|
@brayo-pip I meant like this:
|
|
Very nice! Since you structured your commits and the messages so well, I'll go ahead and skip squash and rebase-merge it :) |
| let autostart_modules = ["aw-module-afk", "aw-module-window"]; | ||
| let autostart_modules = ["aw-watcher-afk", "aw-watcher-window"]; |
Fixes #12
Summary:
This PR enhances module detection by adding functionality to identify and manage 'aw' prefixed executables in the system PATH, and consolidates
tauriimports for cleaner code.Key points:
tauriimports insrc-tauri/src/main.rs.get_modules_in_pathfunction insrc-tauri/src/manager.rsto detect 'aw' prefixed executables in PATH.modules_in_pathinManagerStateto track and manage executable modules found in system PATH.Generated with ❤️ by ellipsis.dev