Skip to content

refactor: remove use of deprecated DateTime::from_utc #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ComputerDruid
Copy link

@ComputerDruid ComputerDruid commented May 29, 2025

Important

Refactor to remove deprecated DateTime::from_utc and update chrono version in Cargo.toml.

  • Refactor:
    • Replace DateTime::from_utc with into() in aw-client-rust/tests/test.rs for timestamp conversion.
  • Dependencies:
    • Update chrono version from 0.4 to 0.4.7 in Cargo.toml.

This description was created by Ellipsis for e0b5d6b. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to e0b5d6b in 41 seconds. Click for details.
  • Reviewed 48 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. aw-client-rust/tests/test.rs:87
  • Draft comment:
    Good refactor: replacing deprecated DateTime::from_utc with .into() is cleaner and correctly converts the parsed DateTime to UTC. Ensure that this implicit conversion matches the original behavior.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. aw-server/Cargo.toml:21
  • Draft comment:
    Explicitly pinning chrono to version 0.4.7 clarifies the dependency. Consider verifying if using the latest compatible patch (e.g., 0.4.x latest) could provide additional bug fixes.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_4ek5POyigNt24t6Z

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.19%. Comparing base (656f3c9) to head (e0b5d6b).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   70.81%   70.19%   -0.63%     
==========================================
  Files          51       51              
  Lines        2916     2939      +23     
==========================================
- Hits         2065     2063       -2     
- Misses        851      876      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant