Simplified rewrite based on photostorm/pty for Windows support - #9

Open

Naatan wants to merge 129 commits into

Commits on Nov 24, 2022

Simplified rewrite based on photostorm/pty for Windows support
Naatan
committed
1f59ff9
Clean up helpers
Naatan
committed
316aaaa

Commits on Dec 5, 2022

WIP
Naatan
committed
723acd1

Commits on Mar 15, 2023

WIP fix order of operation
Naatan
committed
0775f1d

Commits on Mar 17, 2023

Drop overzealous channel closing mechanic, fix tests
Naatan
committed
d7d1070

Commits on Mar 21, 2023

Streamlined option handling. Fixed channel closing issues. Improved error reporting.
Naatan
committed
c8c6e17
Add example tests
Naatan
committed
eff77a9

Commits on Mar 23, 2023

Move responsibility of tracking position to outputProducer
Naatan
committed
03d2a87
Fix timeout not being respected
Naatan
committed
0290250
Remove todo comment that has already been resolved
Naatan
committed
501d5d7
Fix test not exiting
Naatan
committed
ec49284
Test files only contain tests
Naatan
committed
7034515
Ignore intellij .idea folder
Naatan
committed
71af4ba
Fix panic if command executable can't be found
Naatan
committed
1711419

Commits on Apr 11, 2023

Commits on Apr 12, 2023

Fix test failing on mac because input is sent too soon
Naatan
committed
fd91770
Fix test using wrong shell
Naatan
committed
996b10a
Clean up debugging code
Naatan
committed
9d0e991
Drop proof of concept code
Naatan
committed
17ec740
Set up test automation
Naatan
committed
d4a17c4
Format test results
Naatan
committed
a9c1f4c
Debug gotestfmt not on PATH
Naatan
committed
1cf3ff4
Run go mod tidy
Naatan
committed
364d0f2
Debug go version
Naatan
committed
faeba65
Apparently github actions doesn't recognize zero's cause it installed 1.2...
Naatan
committed
43235cb
Prioritize regular tests and report all failures at the end
Naatan
committed
a628c73
Trim NULL bytes from output
Naatan
committed
0a6f5c5
Fix race condition
Naatan
committed
b5d332d
Debug
Naatan
committed
8d20245
Debug timeout
Naatan
committed
befb03f
Remove redundant expect that's moving the buffer
Naatan
committed
9c98f0e
Just run the test once, we already have race tests
Naatan
committed
0574158
Ensure reader has finished before closing
Naatan
committed
ce5a907
Debug
Naatan
committed
8b49c8c
Close pty after reader has finished
Naatan
committed
111abae
Make raw test output available
Naatan
committed
17ac007
Run raw test without json
Naatan
committed
d713761
Initialize termtest with logging for tests
Naatan
committed
dd93617
Close ptmx first again, because windows never throws an EOF and will just block forever
Naatan
committed
852832c
Drop race tests for now. Handle test output directly.
Naatan
committed
4b917e8
Work around race condition for now
Naatan
committed
fbe56d6
Put sleep in the right place
Naatan
committed
27797a2
See if dropping the read interval resolves our race condition
Naatan
committed
b741778

Commits on Apr 13, 2023

Detect EOF on linux
Naatan
committed
fa6a7fb
More debug logging
Naatan
committed
e015682
Address test failure
Naatan
committed
67a4b7a

Commits on Jun 28, 2023

Use named pty fork to avoid conflicts with original
Naatan
committed
9ac1311
Support retrieving full output
Naatan
committed
6ad7b55

Commits on Jun 29, 2023

Add default timeout setting
Naatan
committed
feb9f6e
Drop timed out consumers
Naatan
committed
1a45115

Commits on Jul 5, 2023

WIP: terminal emulation for cursor movement
Naatan
committed
71da3ee

Commits on Aug 23, 2023

Commits on Aug 24, 2023

Commits on Aug 25, 2023

Expose ExpectErrorHandler to facilitate custom expect handlers
Naatan
committed
f1629bc

Commits on Aug 28, 2023

Expect error handler also returns error
Naatan
committed
3703e46
Errors during Send should also bubble up
Naatan
committed
4527c81
Don't error out on a successful operation
Naatan
committed
2c5e0da
Fix windows failures
Naatan
committed
862fa29
Fix unix build failure
Naatan
committed
2d33ea5
Produce Output rather than snapshot when surfacing error
Naatan
committed
2d9cb5e
Allow specifying a custom output sanitizer
Naatan
committed
406fd30

Commits on Aug 30, 2023

Sanitization should happen on the full output so far, because we may want to sanitize output that spans multiple characters
Naatan
committed
b0517b7
Change default cols to something less verbose with whitespace
Naatan
committed
333c9ff
Fix race condition in test
Naatan
committed
a81f2db
Add option for normalizing line endings
Naatan
committed
9b6c30f
Also normalize expect input, and add logging
Naatan
committed
502ea17
Add test that surfaces issue with output containing invalid data
Naatan
committed
9e60c58
Fix test for unix
Naatan
committed
9556798

Commits on Aug 31, 2023

Commits on Sep 1, 2023

Work around pty closing bug on windows
Naatan
committed
d5396a3

Commits on Sep 5, 2023

Fix missing imports
Naatan
committed
d398dc4
Do not normalize input
Naatan
committed
0fb4667
Add test for ensuring timeouts work as expected
Naatan
committed
7d53357

Commits on Sep 11, 2023

Cleaners track cursor position relative to the content they're cleaning
Naatan
committed
33827d0
Fix successive \r's being ignored
Naatan
committed
1efe417

Commits on Sep 12, 2023

Fix cursor position tracking
Naatan
committed
6c6570d
Fix negative index
Naatan
committed
ba23340

Commits on Sep 13, 2023

More tests
Naatan
committed
fccac59
Increased logging
Naatan
committed
3fc7d6b
Fix EOF not triggering a clean of the final output
Naatan
committed
d728543
Wait() should also invoke the expect error handler
Naatan
committed
07c1686
Cleaner should support negative positioning
Naatan
committed
5d89cf8
Fix tests
Naatan
committed
c57d3fb

Commits on Sep 14, 2023

Drop unused
Naatan
committed
6ad7900
Debug special characters
Naatan
committed
da6691a
Also print special characters
Naatan
committed
eb495b7
Enrich timeout errors on expect
Naatan
committed
6e6462e

Commits on Oct 5, 2023

Add test cases for deadlock
Naatan
committed
a5b5d1f
Add write done debug msg
Naatan
committed
718b3c6

Commits on Oct 6, 2023

Allow configuring logger after construction
Naatan
committed
7239daa
Also expose the void logger
Naatan
committed
68c9fe7
Expose constructed void logger to minimize boilerplate for consumers
Naatan
committed
13d903a

Commits on May 16, 2024

Test output expectations should fail if the process has prematurely exited.
mitchell-as
committed
af40d39

Commits on May 22, 2024

Commits on Jun 27, 2024

Reimplement process exit expect failure
Naatan
committed
fddafcc
Drop redundant tests and update original tests
Naatan
committed
e7066bb
Also run tests on PRs targeting v2
Naatan
committed
3a04ace
Ensure test timeout is reached
Naatan
committed
ca9c843
Attempt update pty to see if EOF triggered on Windows
Naatan
committed
2a4438b
Increase Go version
Naatan
committed
0fdda5b
Revert "Increase Go version"
Naatan
committed
822fb35
Revert "Attempt update pty to see if EOF triggered on Windows"
Naatan
committed
ef53e28

Commits on Jun 28, 2024

Windows doesn't send pty EOF unless wait is called
Naatan
committed
e176b0b
Merge pull request #13 from ActiveState/DX-2901
Naatan
authored
3b5b4ea
Ensure time is provided AFTER process state has been asserted
Naatan
committed
ac3b175

Commits on Jul 3, 2024

Merge pull request #14 from ActiveState/DX-2901
Naatan
authored
34f7899

Commits on Aug 19, 2025

Commits on Aug 20, 2025

Fix windows test
Naatan
committed
90926e4
Merge pull request #15 from ActiveState/CP-1034
Naatan
authored
792af93