Update windows runner to 2025 #3705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using SHA1 instead of SHA256 as SHA1 is the old behaviour, and this commit is not about changing the behaviour
|
I have an idea of which integration test errors have been erroring for a while on each platform. I will check on this tomorrow after these jobs complete and let you know what might be new and we'll go from there. |
mitchell-as
requested changes
Aug 14, 2025
There was a problem hiding this comment.
Still failing:
- TestAnalyticsIntegrationTestSuite/TestAttempts
- TestErrorsIntegrationTestSuite/TestMultiErrorWithInput
- TestErrorsIntegrationTestSuite/TestMultiErrorWithoutInput
- TestShellIntegrationTestSuite/TestShell
- TestShellsIntegrationTestSuite/TestShells/using_cmd.exe
The rest are either known failures or sporadic ones I can overlook.
mitchell-as
approved these changes
Aug 20, 2025
There was a problem hiding this comment.
TestShellIntegrationTestSuite/TestShell is not being tested.
I will approve this. If you want to roll the dice, commit it without testing it, and the test fails overnight, I will file a ticket in the morning.
Anyway, good work. This was not an easy task, and very annoying to deal with I'm sure. I myself was not looking forward to picking this one up...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I validated as much as I can without actually running this against a release branch, but it seems unlikely that release specific logic would be impacted by the host runner.
Integration tests are failing. I dug into the failures but they are all seemingly unrelated. It doesn't help that we have a number of failing integration tests already and the last windows run is not retained on github actions due to its age, so I can't compare. End of the day we'll have to treat fixing up our integration tests as a separate story.