Skip to content

chore: update the xtermjs to v6 and fix session creation#2487

Merged
bajrangCoder merged 9 commits into
mainfrom
chore/update-xtermjs
Jul 20, 2026
Merged

chore: update the xtermjs to v6 and fix session creation#2487
bajrangCoder merged 9 commits into
mainfrom
chore/update-xtermjs

Conversation

@bajrangCoder

@bajrangCoder bajrangCoder commented Jul 12, 2026

Copy link
Copy Markdown
Member
  • Updated the themes with new fields
  • Added option to turn off the xtermjs scrollabr
  • Fixed touch related stuff introduced in new version
  • fix(terminal): wait for AXS server readiness before creating session

- updated the themes with new fields
- added option to turn off the xtermjs scrollabr
- fixed touch related stuff introduced in new version
@bajrangCoder
bajrangCoder marked this pull request as ready for review July 12, 2026 13:48
@greptile-apps

greptile-apps Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the terminal stack for xterm.js v6. The main changes are:

  • xterm.js and related addons upgraded to v6-compatible versions.
  • Terminal themes updated for the new selection and scrollbar theme fields.
  • A setting added to show or hide the terminal scrollbar.
  • Touch scrolling and selection adjusted for the new scrollbar behavior.
  • Terminal startup and resize sync updated around AXS readiness and WebSocket reconnects.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The scrollbar option now handles missing overview-ruler settings safely.
  • The terminal resize path now forces a server sync when the WebSocket opens.

Important Files Changed

Filename Overview
src/components/terminal/terminal.js Adds scrollbar visibility handling, background updates, server readiness polling, and forced fit/resize sync.
src/settings/terminalSettings.js Adds the showScrollbar setting and applies it to active terminals.
src/components/terminal/terminalManager.js Updates terminal styling for xterm v6 scrollbar and viewport behavior.
src/components/terminal/terminalTouchScrolling.js Moves touch scrolling to xterm public scrolling APIs for v6 compatibility.
src/components/terminal/terminalTouchSelection.js Updates touch selection handling for xterm v6 scroll and resize events.
src/components/terminal/terminalThemeManager.js Migrates terminal themes to xterm v6 field names and normalizes legacy plugin themes.

Reviews (4): Last reviewed commit: "fix(terminal): wait for AXS server readi..." | Re-trigger Greptile

Comment thread src/components/terminal/terminal.js Outdated
Comment thread src/components/terminal/terminal.js Outdated
@RohitKushvaha01 RohitKushvaha01 added the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Jul 12, 2026
@bajrangCoder

This comment was marked as outdated.

Comment thread src/components/terminal/terminal.js Outdated
@bajrangCoder

This comment was marked as outdated.

@bajrangCoder

This comment was marked as outdated.

@bajrangCoder bajrangCoder changed the title chore: update the xtermjs to v6 chore: update the xtermjs to v6 and fix session creation Jul 12, 2026
@bajrangCoder bajrangCoder added CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. and removed CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. labels Jul 12, 2026
@UnschooledGamer UnschooledGamer added CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. and removed CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. labels Jul 12, 2026
@github-actions github-actions Bot removed the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Jul 12, 2026
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

Preview Release for this, has been built.

Click here to view that github actions build

@RohitKushvaha01 RohitKushvaha01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bajrangCoder
bajrangCoder merged commit c2c308a into main Jul 20, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Jul 20, 2026
@bajrangCoder
bajrangCoder deleted the chore/update-xtermjs branch July 20, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants