Fix: Remove trimming of matched content in Executor.js#1798
Fix: Remove trimming of matched content in Executor.js#1798RohitKushvaha01 merged 1 commit intoAcode-Foundation:mainfrom
Conversation
The output should not be trimmed. Using trim() breaks streamed output (line-by-line) because it removes leading spaces. This results in invalid output for many use cases, such as diffs and git status symbol.
Summary of ChangesHello @dikidjatar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the application of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where leading whitespace was being trimmed from command output in Executor.js. By removing the .trim() call, the change ensures that streamed output, especially for commands like git status or diff that rely on indentation for formatting, is preserved correctly. The addition of a newline at the end of the file is also a good housekeeping change. The changes are accurate and improve the correctness of the terminal output.
The output should not be trimmed. Using trim() breaks streamed output (line-by-line) because it removes leading spaces. This results in invalid output for many use cases, such as diffs and git status symbol.