chore: message type detection in release notes script#1786
chore: message type detection in release notes script#1786UnschooledGamer merged 2 commits intomainfrom
Conversation
Summary of ChangesHello @UnschooledGamer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the commit message parsing within the release notes generation script. It ensures that commit messages following the conventional commit format, specifically those including a scope (e.g., Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Who asked Gemini to review ahhh? it's just a small change lol. |
There was a problem hiding this comment.
Code Review
This pull request updates the release notes generation script to correctly categorize commits that use a scope in their type, such as feat(plugin): .... The change is a good improvement for handling more diverse commit message formats. My review includes a suggestion to simplify the detection logic by removing redundant checks and using a regular expression, which would improve maintainability and clarity.
updates the Release notes script to pick up scoped commits (i.e
feat(plugin)), instead of ignoring them