Skip to content

feat. added system theme#1321

Merged
RohitKushvaha01 merged 11 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:main
May 29, 2025
Merged

feat. added system theme#1321
RohitKushvaha01 merged 11 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:main

Conversation

@RohitKushvaha01
Copy link
Member

@RohitKushvaha01 RohitKushvaha01 commented May 25, 2025

This PR adds support for a dynamic theme that follows the system's light or dark mode.
Closes #746

@RohitKushvaha01 RohitKushvaha01 marked this pull request as draft May 25, 2025 06:20
@Acode-Foundation Acode-Foundation deleted a comment from buyersmile May 25, 2025
@RohitKushvaha01 RohitKushvaha01 marked this pull request as ready for review May 27, 2025 07:25
@RohitKushvaha01
Copy link
Member Author

should i make this theme default? (#746)

@UnschooledGamer
Copy link
Member

should i make this theme default? (#746)

Yes. And Maybe add a toast message when the user starts the app for the first time (new installation) saying it defaults to system-based theme now.

@hackesofice
Copy link
Contributor

should i make this theme default? (#746)

I think asking at start-up is the better/best option.

@RohitKushvaha01 RohitKushvaha01 merged commit 52bf3a5 into Acode-Foundation:main May 29, 2025
2 checks passed
Copy link

@Lukier1316 Lukier1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/lib/systemConfiguration.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow OS theme by default

5 participants