feat: rainbow bracket pair colorizer #1259
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 16 out of 35 changed files in this pull request and generated no comments.
Files not reviewed (19)
- src/lang/ar-ye.json: Language not supported
- src/lang/be-by.json: Language not supported
- src/lang/bn-bd.json: Language not supported
- src/lang/cs-cz.json: Language not supported
- src/lang/de-de.json: Language not supported
- src/lang/en-us.json: Language not supported
- src/lang/es-sv.json: Language not supported
- src/lang/fr-fr.json: Language not supported
- src/lang/hi-in.json: Language not supported
- src/lang/hu-hu.json: Language not supported
- src/lang/id-id.json: Language not supported
- src/lang/ir-fa.json: Language not supported
- src/lang/it-it.json: Language not supported
- src/lang/ja-jp.json: Language not supported
- src/lang/ko-kr.json: Language not supported
- src/lang/ml-in.json: Language not supported
- src/lang/mm-unicode.json: Language not supported
- src/lang/mm-zawgyi.json: Language not supported
- src/lang/pl-pl.json: Language not supported
Comments suppressed due to low confidence (2)
src/ace/rainbowBracktes.js:1
- The file name 'rainbowBracktes.js' appears to be misspelled. Consider renaming it to 'rainbowBrackets.js' for clarity.
/* Filename 'rainbowBracktes.js' */
src/ace/rainbowBracktes.js:268
- Appending the style class directly to token.type without verifying if it already contains similar classes might lead to duplicate class entries in cases where the token length is greater than one. Consider refactoring the logic to ensure the class is added only once.
token.type += ` rainbow-level-${colorLevel}`;
Contributor
|
So, we should implement it ourselves as a plugin? |
Member
Author
There is a plugin available( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds Rainbow brackets pair colorizer similar to vscode one.
Demo