-
Notifications
You must be signed in to change notification settings - Fork 802
fix. http relative path #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bajrangCoder
merged 19 commits into
Acode-Foundation:main
from
RohitKushvaha01:fix-relative-path
Apr 15, 2025
Merged
fix. http relative path #1257
bajrangCoder
merged 19 commits into
Acode-Foundation:main
from
RohitKushvaha01:fix-relative-path
Apr 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There are multiple problems:
|
Member
Author
|
Member
|
Now things are fine. But still needs some fixes in these cases:
In these cases it should fallback as previous. When running a |
Member
Author
|
this is gonna take some more time, every change breaks something else |
Member
Author
|
@bajrangCoder can you test this?, It's working in my device |
Member
I'll test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1091 , #651
HTML viewer now resolves relative paths
Before:

Now:

This change might break something. I recommend testing it before merging.