Skip to content

Conversation

@RohitKushvaha01
Copy link
Member

@RohitKushvaha01 RohitKushvaha01 commented Apr 12, 2025

Closes: #1091 , #651

HTML viewer now resolves relative paths

Before:
image

Now:
image

This change might break something. I recommend testing it before merging.

@bajrangCoder
Copy link
Member

There are multiple problems:

  • saf uri contains many special stuffs like ::primary:, or termux saf uri etc which needs to be stripped out
  • also problem with SFTP/ftp url as they typically starts with protocol SFTP/ftp
  • and there should be fallback if there is no folders in added folder or any other case then just serve the current document

@RohitKushvaha01 RohitKushvaha01 marked this pull request as draft April 12, 2025 10:29
@RohitKushvaha01
Copy link
Member Author

RohitKushvaha01 commented Apr 13, 2025

  • Internal Storage
  • Termux
  • FTP
  • Redirect to current file

@RohitKushvaha01 RohitKushvaha01 marked this pull request as ready for review April 13, 2025 10:48
@bajrangCoder
Copy link
Member

bajrangCoder commented Apr 13, 2025

Now things are fine. But still needs some fixes in these cases:

  • when a file is opened which is not saved on storage (it's in cache)
  • when a file is opened and there is no folders in sidebar
  • when a file is opened but that's not the part of any Opened folder in sidebar

In these cases it should fallback as previous.

When running a .js file it opens browser but it should open js console

@RohitKushvaha01 RohitKushvaha01 marked this pull request as draft April 14, 2025 06:14
@RohitKushvaha01 RohitKushvaha01 marked this pull request as ready for review April 14, 2025 07:32
@RohitKushvaha01 RohitKushvaha01 marked this pull request as draft April 14, 2025 07:50
@RohitKushvaha01
Copy link
Member Author

this is gonna take some more time, every change breaks something else

@RohitKushvaha01
Copy link
Member Author

@bajrangCoder can you test this?, It's working in my device

@bajrangCoder
Copy link
Member

@bajrangCoder can you test this?, It's working in my device

I'll test it

@RohitKushvaha01 RohitKushvaha01 marked this pull request as ready for review April 15, 2025 03:07
@bajrangCoder bajrangCoder merged commit 12383ff into Acode-Foundation:main Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for relative assets handling in built in server

2 participants