Skip to content

feat: enable bouncy castle for sftp#1227

Merged
bajrangCoder merged 1 commit intoAcode-Foundation:mainfrom
bajrangCoder:enable-bouncy-castle
Mar 27, 2025
Merged

feat: enable bouncy castle for sftp#1227
bajrangCoder merged 1 commit intoAcode-Foundation:mainfrom
bajrangCoder:enable-bouncy-castle

Conversation

@bajrangCoder
Copy link
Member

No description provided.

@bajrangCoder bajrangCoder mentioned this pull request Mar 24, 2025
1 task
@bajrangCoder bajrangCoder requested a review from Copilot March 27, 2025 02:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables Bouncy Castle for SFTP to enhance cryptographic support during SFTP operations.

  • Adds an import for JCEProvider.
  • Inserts calls to enable Bouncy Castle in two separate locations within the run() method.
Files not reviewed (1)
  • src/plugins/sftp/plugin.xml: Language not supported
Comments suppressed due to low confidence (2)

src/plugins/sftp/src/com/foxdebug/sftp/Sftp.java:98

  • [nitpick] The call to enable Bouncy Castle here appears to be duplicated later in the method. Consider centralizing this call to reduce redundant initialization.
JCEProvider.enableBouncyCastle(true);

src/plugins/sftp/src/com/foxdebug/sftp/Sftp.java:181

  • [nitpick] This duplicate call may be unnecessary if Bouncy Castle is already enabled earlier. Consolidating the initialization could simplify the code.
JCEProvider.enableBouncyCastle(true);

@bajrangCoder bajrangCoder merged commit 3b6d3f7 into Acode-Foundation:main Mar 27, 2025
2 checks passed
@bajrangCoder bajrangCoder deleted the enable-bouncy-castle branch May 9, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant