Skip to content

handle few edge cases on plugins page #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 1 commit into from
Mar 4, 2025
Merged

handle few edge cases on plugins page #1203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/installPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ export default async function installPlugin(
isDependency,
) {
if (!isDependency) {
loaderDialog = loader.create(name || "Plugin", strings.installing);
loaderDialog = loader.create(name || "Plugin", strings.installing, {
timeout: 6000,
});
depsLoaders = [];
}

Expand Down
19 changes: 17 additions & 2 deletions src/pages/plugins/item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ export default function Item({
downloads,
installed,
}) {
const authorName = (() => {
const displayName =
typeof author === "object" ? author.name : author || "Unknown";
// Check if it's likely an email or too long
if (displayName.includes("@") || displayName.length > 20) {
return displayName.substring(0, 20) + "...";
}
return displayName;
})();

return (
<div
data-id={id}
Expand All @@ -43,9 +53,14 @@ export default function Item({
<span className="plugin-version">v{version}</span>
</div>
<div className="plugin-meta">
<div className="plugin-stats">
<div
className="plugin-stats plugin-author"
title={
typeof author === "object" ? author.name : author || "Unknown"
}
>
<span className="icon person"></span>
{typeof author === "object" ? author.name : author || "Unknown"}
{authorName}
{author_verified ? (
<i
className="licons verified"
Expand Down
39 changes: 34 additions & 5 deletions src/pages/plugins/plugins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
transition: background-color 0.15s ease;
display: flex;
align-items: center;
overflow-x: hidden;
&:hover {
background: color-mix(in srgb, var(--primary-color) 20%, transparent);
}
Expand Down Expand Up @@ -88,6 +89,7 @@
text-overflow: ellipsis;
white-space: nowrap;
min-width: 0;
max-width: calc(100% - 50px);
}
.plugin-version {
color: color-mix(in srgb, var(--secondary-text-color) 80%, black);
Expand All @@ -103,6 +105,7 @@
font-size: 0.81rem;
color: color-mix(in srgb, var(--secondary-text-color) 80%, black);
display: flex;
flex-wrap: wrap;
gap: 0.375rem;
align-items: center;
.plugin-meta-dot {
Expand All @@ -114,12 +117,21 @@
black
);
border-radius: 50%;
display: inline-block;
}
.plugin-stats {
display: flex;
align-items: center;
gap: 0.25rem;
font-size: 0.81rem;

&.plugin-author {
max-width: 150px;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}

.icon {
display: inline-flex;
align-items: center;
Expand All @@ -128,6 +140,7 @@
height: 12px;
font-size: 12px;
line-height: 1;
flex-shrink: 0;
}
}
}
Expand All @@ -148,13 +161,29 @@
}
}

@media (max-width: 480px) {
.plugin-title {
flex-wrap: wrap;
@media (max-width: 380px) {
.plugin-header {
.plugin-info {
flex-direction: column;
align-items: flex-start;

.plugin-price {
margin-top: 4px;
align-self: flex-start;
}
}
}

.plugin-name {
max-width: calc(100% - 1rem);
.plugin-meta {
margin-top: 2px;

.plugin-meta-dot {
display: none;
}

.plugin-stats {
margin-right: 8px;
}
}
}
}
Expand Down