Skip to content

fix: infinite scroll on plugin page #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 1 commit into from
Feb 2, 2025
Merged

fix: infinite scroll on plugin page #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions src/pages/plugins/plugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,12 @@ export default function PluginsInclude(updates) {

$page.onclick = handleClick;

$list.all.addEventListener('scroll', (e) => {
$list.all.addEventListener('scroll', async (e) => {
if (isLoading || !hasMore) return;

const { scrollTop, scrollHeight, clientHeight } = $currList;
const { scrollTop, scrollHeight, clientHeight } = e.target;
if (scrollTop + clientHeight >= scrollHeight - 100) {
if (currSection === "all") {
currentPage++;
getAllPlugins();
}
await getAllPlugins();
}
})

Expand Down Expand Up @@ -225,8 +222,13 @@ export default function PluginsInclude(updates) {
$section.scrollTop = $section._scroll || 0;
$currList = $section;
currSection = section;
currentPage = 1;
hasMore = true;
if (section === "all") {
currentPage = 1;
hasMore = true;
isLoading = false;
$list.all.replaceChildren();
getAllPlugins();
}
$page.get(".options .active").classList.remove("active");
$page.get(`#${section}_plugins`).classList.add("active");
}
Expand Down Expand Up @@ -284,35 +286,30 @@ export default function PluginsInclude(updates) {

try {
isLoading = true;
if (currentPage === 1) {
plugins.all = [];
$list.all.replaceChildren();
}

$list.all.setAttribute("empty-msg", strings["loading..."]);

const installed = await fsOperation(PLUGIN_DIR).lsDir();
const response = await fetch(`${constants.API_BASE}/plugins?page=${currentPage}&limit=${LIMIT}`);
const newPlugins = await response.json();

if (newPlugins.length < LIMIT) {
hasMore = false;
}

plugins.all = [...plugins.all, ...newPlugins];

const installed = await fsOperation(PLUGIN_DIR).lsDir();
installed.forEach(({ url }) => {
const plugin = plugins.all.find(({ id }) => id === Url.basename(url));
const plugin = newPlugins.find(({ id }) => id === Url.basename(url));
if (plugin) {
plugin.installed = true;
plugin.localPlugin = getLocalRes(plugin.id, "plugin.json");
}
});

plugins.all.forEach((plugin) => {
newPlugins.forEach((plugin) => {
$list.all.append(<Item {...plugin} />);
});

currentPage++;
$list.all.setAttribute("empty-msg", strings["no plugins found"]);
} catch (error) {
window.log("error", error);
Expand Down
10 changes: 5 additions & 5 deletions www/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,11 @@

<title>Acode</title>
<!--styles-->
<link rel="stylesheet" href="./css/build/100.css">
<link rel="stylesheet" href="./css/build/138.css">
<link rel="stylesheet" href="./css/build/543.css">
<link rel="stylesheet" href="./css/build/879.css">
<link rel="stylesheet" href="./css/build/922.css">
<link rel="stylesheet" href="./css/build/218.css">
<link rel="stylesheet" href="./css/build/32.css">
<link rel="stylesheet" href="./css/build/383.css">
<link rel="stylesheet" href="./css/build/53.css">
<link rel="stylesheet" href="./css/build/609.css">
<link rel="stylesheet" href="./css/build/about.css">
<link rel="stylesheet" href="./css/build/customTheme.css">
<link rel="stylesheet" href="./css/build/donate.css">
Expand Down