ADG-414 Improve code quality with github actions #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for accessibility-developer-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rudigier
changed the title
backflip
reviewed
Jun 29, 2023
.github/workflows/codeQuality.yml
Outdated
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [master] |
There was a problem hiding this comment.
@rudigier, shouldn't this be main?
backflip
reviewed
Jun 29, 2023
.github/workflows/codeQuality.yml
Outdated
| @@ -0,0 +1,29 @@ | |||
| # | |||
| # linter and dependancy cruiser tests | |||
There was a problem hiding this comment.
What is dependancy cruiser?
|
Wow, that was quick! Could we run the fix jobs and commit the changes in this workflow? I don't see any upside in still having to do this locally. |
|
@backflip: pr bitte nochmals reviewen |
This reverts commit ced38f0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.