Repository navigation
feat(shotgrid): support PROJECT_ALLOWED_TYPES filtering - #262
Merged
jspada200 merged 3 commits intoNov 21, 2026
Conversation
|
|
jspada200
self-requested a review
November 2, 2026 15:12
Collaborator
|
Looks good @KrishnaAdityaSrivastava ! Can you document this new variable here? https://github.com/AcademySoftwareFoundation/dna/blob/main/QUICKSTART.md Thanks! |
KrishnaAdityaSrivastava
force-pushed
the
feat/shotgrid-project-allowed-types
branch
from
November 3, 2026 06:09
6ee33e7 to
8164326
Compare
Collaborator
|
Sothing got a little messed up on this branch. Let me know if you need help to wrap this up. |
This was referenced Nov 18, 2026
KrishnaAdityaSrivastava
force-pushed
the
feat/shotgrid-project-allowed-types
branch
from
November 19, 2026 05:48
8164326 to
22cb3c6
Compare
Signed-off-by: KrishnaAdityaSrivastava <krishnaadityasrivastava@gmail.com>
Signed-off-by: KrishnaAdityaSrivastava <krishnaadityasrivastava@gmail.com>
KrishnaAdityaSrivastava
force-pushed
the
feat/shotgrid-project-allowed-types
branch
from
November 19, 2026 05:51
22cb3c6 to
6220b62
Compare
Contributor
Author
|
Hey, I fixed the branch. Some unrelated commits had accidentally crept in when I updated it. I have cleaned it up and added the |
jspada200
approved these changes
Nov 21, 2026
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for filtering ShotGrid projects by project type using the
PROJECT_ALLOWED_TYPESenvironment variable.When
PROJECT_ALLOWED_TYPESis set (for example,Commercial,Feature),get_projects_for_user()adds ansg_typefilter to the ShotGrid query so that only projects whosesg_typematches one of the configured values are returned. When the environment variable is unset or empty, the existing behavior is preserved.Also adds unit tests covering:
PROJECT_ALLOWED_TYPESconfigured.Testing
How I Tested
PROJECT_ALLOWED_TYPESto different values and verified the generated ShotGrid filters through unit tests.Fixes #254